[Pidgin] #1535: Trivial: #if GTK_CHECK_VERSION(2, 6, 0) make about menu item a stock item

Pidgin trac at pidgin.im
Wed Jun 6 08:03:50 EDT 2007


#1535: Trivial: #if GTK_CHECK_VERSION(2,6,0) make about menu item a stock item
---------------------------+------------------------------------------------
  Reporter:  nix_nix       |       Owner:  hbons
      Type:  patch         |      Status:  new  
  Priority:  minor         |   Milestone:  2.0.2
 Component:  pidgin (gtk)  |     Version:  2.0.1
Resolution:                |    Keywords:       
   Pending:  0             |  
---------------------------+------------------------------------------------
Comment (by hbons):

 Replying to [comment:6 nix_nix]:
 > Replying to [comment:3 rlaager]:
 > > nix_nix: What advantage does this provide you?
 >
 > No advantage. It's a cosmetic change. I figure we should use stock items
 in all instances where GTK provides such stock items. Then there's always
 the "every other GTK app" argument ...

 I don't agree. The menu's look much cleaner and are more usable when only
 the mostly used entries have icons. (Look at the change from 2.0 early
 beta's and 2.0 final)

 Sean: Why did you move it to "Buddies"? Because you want to get rid of the
 "Help" menu? If so, I don't really care, but if not it's better to leave
 it where it is because "every other GTK app has it there".

-- 
Ticket URL: <http://developer.pidgin.im/ticket/1535#comment:7>
Pidgin <http://pidgin.im>
Pidgin


More information about the Tracker mailing list