[Pidgin] #1653: Fetch and update Yahoo server-based aliases
Pidgin
trac at pidgin.im
Wed Jun 27 12:54:56 EDT 2007
#1653: Fetch and update Yahoo server-based aliases
------------------------+---------------------------------------------------
Reporter: johnmoody | Owner: seanegan
Type: patch | Status: assigned
Priority: minor | Milestone: 2.1.0
Component: libpurple | Version: 2.0.1
Resolution: | Keywords: yahoo alias
Pending: 0 |
------------------------+---------------------------------------------------
Comment (by seanegan):
This looks really good; thanks for doing it.
A few comments/questions:
In most Asian languages, the family name comes before the given name.
Perhaps it's not always right to do "fn ln"? What's the Yahoo! Messenger
UI for this like?
Instead of calling purple_blist_alias_buddy() (or whatever it's called),
call serv_got_alias(). Libpurple has different concepts for "aliases set
by the user," and "alias set by the server," so that they don't wipe each
other out.
You said you hooked the "set alias" function to "Get Info"? That seems a
little unnatural. What was wrong with the "alias_buddy" prpl function?
Can you create a new function in util.c to GET a URI with a GList, or do
it variatically, or do just a string, or whatever... that gets an URI with
a passed-in list of headers? And then make the existing function call
that, passing in its User-agent header? Then make your .c file call that?
I don't like overloading the user-agent field the way you did.
--
Ticket URL: <http://developer.pidgin.im/ticket/1653#comment:3>
Pidgin <http://pidgin.im>
Pidgin
More information about the Tracker
mailing list