[Pidgin] #519: Allow a filtering function in the buddy autocompletion

Pidgin trac at pidgin.im
Tue May 1 20:55:31 EDT 2007


#519: Allow a filtering function in the buddy autocompletion
---------------------------+------------------------------------------------
  Reporter:  lmfe          |       Owner:     
      Type:  patch         |      Status:  new
  Priority:  minor         |   Milestone:     
 Component:  pidgin (gtk)  |     Version:  2.0
Resolution:                |    Keywords:     
   Pending:  0             |  
---------------------------+------------------------------------------------
Comment (by lmfe):

 The first patch is, say, a refactoring of the current code. It's not
 really a refactoring, but more to keep things somewhat consistent and
 clearer.
 I found that there are actually two ways for autocomplete, and the two are
 #ifdef'ed, and have completely different behavior. The structure
 PidginCompletionData didn't even existed in the new style completion. This
 caused some functions having different signatures, depending on the #ifdef
 branch (take for example add_completion_list).

 In this first patch, what I did was:[[BR]]
 * Created the PidginCompletionData structure in both #ifdef
 branches.[[BR]]
 * Added some more fields to this structure.[[BR]]
 * Get rid of the 2-position arrays that were being passed as callback
 data, and used the PidginCompletionData for callbacks instead.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/519#comment:5>
Pidgin <http://pidgin.im>
Pidgin


More information about the Tracker mailing list