[Pidgin] #398: Crash when updating a buddy's icon on MSN

[Pidgin]

#398: Crash when updating a buddy's icon on MSN
---------------------------+------------------------------------------------
  Reporter:  nosnilmot     |       Owner:  seanegan
      Type:  defect        |      Status:  assigned
  Priority:  blocker       |   Milestone:  2.0.0   
 Component:  pidgin (gtk)  |     Version:  2.0     
Resolution:                |    Keywords:          
   Pending:  0             |  
---------------------------+------------------------------------------------
Comment (by sadrul):

 I don't think that patch is going to help. Try this one instead:
 http://pidgin.im/~sadrul/pp/buddyicon-crash-2.patch

 What happens is, when icon is unset, icon->img is NULL, so icon_to_set is
 also NULL. purple_buddy_set_icon causes icon to be unref-ed, thus freed.
 Using icon after that causes the crash. The fix here moves _set_icon after
 when icon is not used anymore.

 I have not been able to get a crash with or without the patch, so I might
 be wrong.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/398#comment:7>
Pidgin <http://pidgin.im>
Pidgin