[Pidgin] #533: GAIM_MESSAGE_RAW flag never used, even for not formatted messages
Pidgin
trac at pidgin.im
Wed May 2 05:00:46 EDT 2007
#533: GAIM_MESSAGE_RAW flag never used, even for not formatted messages
--------------------------+-------------------------------------------------
Reporter: asashnov | Type: enhancement
Status: new | Priority: minor
Component: pidgin (gtk) | Version: 2.0
Keywords: | Pending: 0
--------------------------+-------------------------------------------------
How to reproduce:
* grep in source code for GAIM_MESSAGE_RAW - this flag checking, but never
set up.
libgaim/conversation.c: common_send():
/* Always linkfy the text for display */
displayed = gaim_markup_linkify(message);
if ((conv->features & GAIM_CONNECTION_HTML) &&
!(msgflags & GAIM_MESSAGE_RAW))
{
sent = g_strdup(displayed);
}
else
sent = g_strdup(message);
(msgflags & GAIM_MESSAGE_RAW) is always == 0 because it never set up in
code.
Seems good place for setup GAIM_MESSAGE_RAW somewhere in gtk/gtkconv.c:
send_cb() IMHO.
But I see no way to make decision 'is formatting used' or not in
gtk/gtkimhtml.c
--
Ticket URL: <http://developer.pidgin.im/ticket/533>
Pidgin <http://pidgin.im>
Pidgin
More information about the Tracker
mailing list