[Pidgin] #649: pidgin 2.0.0 does not compile on Solaris 9

[Pidgin]

#649: pidgin 2.0.0 does not compile on Solaris 9
---------------------------+------------------------------------------------
  Reporter:  rsk308        |       Owner:  evands                                         
      Type:  defect        |      Status:  new                                            
  Priority:  minor         |   Milestone:  2.0.1                                          
 Component:  pidgin (gtk)  |     Version:  2.0                                            
Resolution:                |    Keywords:  2.0.0 solaris libpurple stdint.h sysctl.h err.h
   Pending:  0             |  
---------------------------+------------------------------------------------
Comment (by evands):

 1. The patch works just fine for me; see below for why non-glib types were
 used previously
  2. This is because the original nat-pmp code (a BSD licensed library I
 took in and modified for use in libpurple) used functions from err.h all
 over the place (and didn't depend upon glib for types, memory allocation,
 etc.). I replaced those with better error handling and purple_debug()
 calls as appropriate but neglected to remove the #include for err.h.
 Removing it is fine.
  3. I'm not sure, either. My man page says that sysctl() is available in
 BSD, and rsk308's make error seems to signify that it's not available at
 all on Solaris 9. If it's available at all, and the constants used here
 are available, I would expect it to work, since we use sysctl() first to
 find out the size of the returned data and then use it again to actually
 retrieve that data.  I guess at the least a configure-time check is in
 order, with {{{HAVE_SYSCTL_H}}} protecting the functional code along with
 the  {{{ #ifdef NET_RT_DUMP }}} already in place, which I'd hoped would be
 enough to keep non-compatible platforms away from it.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/649#comment:4>
Pidgin <http://pidgin.im>
Pidgin