[Pidgin] #702: info not reset on url redirect

Pidgin trac at pidgin.im
Sun May 6 11:51:45 EDT 2007


#702: info not reset on url redirect
-----------------------------------------------+----------------------------
 Reporter:  jashar                             |       Type:  patch
   Status:  new                                |   Priority:  minor
Component:  libpurple                          |    Version:  2.0  
 Keywords:  redirect request_written data_len  |    Pending:  0    
-----------------------------------------------+----------------------------
 This section of util.c:
 {{{
 purple_input_remove(gfud->inpa);
 gfud->inpa = 0;
 close(gfud->fd);
 gfud->fd = -1;
 }}}
 should include:
 {{{
 gfud->request_written = 0;
 gfud->len = 0;
 gfud->data_len = 0;
 }}}
 also might want to change:
 {{{
 if (gfud->request_written != total_len)
 }}}
 to:
 {{{
 if (gfud->request_written < total_len)
 }}}
 so that we don't get stuck in an infinite loop when the redirect request
 is shorter than the original.

 also may want to change the "Location:" parsing in case we hit a URL that
 redirects to itself.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/702>
Pidgin <http://pidgin.im>
Pidgin


More information about the Tracker mailing list