[Pidgin] #648: msimprpl-20070502 snapshot crashes Pidgin 2.0.0

[Pidgin]

#648: msimprpl-20070502 snapshot crashes Pidgin 2.0.0
--------------------------+-------------------------------------------------
  Reporter:  alan.cramer  |       Owner:  jeff         
      Type:  defect       |      Status:  reopened     
  Priority:  minor        |   Milestone:               
 Component:  libpurple    |     Version:  2.0          
Resolution:               |    Keywords:  msim msimprpl
   Pending:  0            |  
--------------------------+-------------------------------------------------
Changes (by rlaager):

  * status:  closed => reopened
  * resolution:  fixed =>

Comment:

 A few points:
  1. If you want bug reports on your code in MTN, that's fine by me, but my
 comment stands in general. ;)
  2. The changeset your referenced includes separate, unrelated changes
 (such as #if to #ifdef). Don't do that. It's not that much work to
 separate things out and commit them independently, with proper commit
 messages. This becomes really useful later for merging, reverting, bug
 fixing, etc.
  3. This should not have crashed, period. The fact that it did means you
 didn't have proper error checking on your cipher code. You need to fix
 this either way.
  4. If your branch has RC4 support in its libpurple/cipher.c, then the
 problem is not your code. The problem is that someone compiled Pidgin
 (from your branch) but not the corresponding libpurple from your branch.
 It's perfectly reasonable to expect that people working with an
 experimental branch will do the right thing. I think it's a bad idea to
 have your own copy in, just for compatibility with a libpurple.so.0.0.0
 from another source. It increases the size of the diffs and is confusing.
 If you want, you could just merge the RC4 code, but (depending on how we
 interpret ciphers w.r.t. API compatibility) that may mean we'd have to
 bump to 2.1.0. If nothing else, I'd recommend you merge the RC4 at the
 point that we commit something else that makes it 2.1.0.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/648#comment:4>
Pidgin <http://pidgin.im>
Pidgin