[Pidgin] #647: Jabber authorisation requests crash gaim

[Pidgin]

#647: Jabber authorisation requests crash gaim
------------------------+---------------------------------------------------
  Reporter:  pedric     |       Owner:  nwalp   
      Type:  defect     |      Status:  assigned
  Priority:  major      |   Milestone:  2.0.1   
 Component:  libpurple  |     Version:  2.0     
Resolution:             |    Keywords:          
   Pending:  0          |  
------------------------+---------------------------------------------------
Comment (by seanegan):

 Replying to [comment:7 nwalp]:
 > Sean, this seems to be caused by your commit of
 4c8e9091a9db7b051ad4394fdea2cbe4f75ffa4c.  We're freeing the presence when
 deleting 1 of 2 or more buddies that share a presence.  Why did you remove
 the reference counting and such?

 Because I'm a total moron and missed the case of multiple GaimBuddy
 instances referring to the same buddy. I got the impression that was
 intended to be used to prevent multiple instances of GaimPrence, shared
 amongst many buddies, that were all "Available with no status message,"
 but that it was never actually implemented. I got a few people in #pidgin
 to agree before making the change, so I don't feel too bad.

 Nathan's looking at what the best way to fix this is, but yeah, I screwed
 up.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/647#comment:8>
Pidgin <http://pidgin.im>
Pidgin