[Pidgin] #96: Clicking on a buddy name in a chat window should alias the name
Pidgin
trac at pidgin.im
Fri May 11 16:33:10 EDT 2007
#96: Clicking on a buddy name in a chat window should alias the name
---------------------------+------------------------------------------------
Reporter: jiri.pejchal | Owner: seanegan
Type: enhancement | Status: assigned
Priority: minor | Milestone:
Component: pidgin (gtk) | Version: 2.0
Resolution: | Keywords:
Pending: 0 |
---------------------------+------------------------------------------------
Comment (by seanegan):
I like this. A few comments:
- You add tab_entry in the middle of the PidginConversation struct. Since
that would throw off all the offsets, that would require a major version
bump (3.0.0).
- Adding tab_entry to the end of the struct would keep it from requiring
3.0.0, but would still require a minor version bump to 2.1.0. We're
planning on the next release being primarily a bugfix, 2.0.1 release, so,
unless you can think of a clean way to do this without adding anything to
the struct (which is probably possible), this would have to wait until
after then.
- You should connect the signal to each GtkLabel individually. That will
save the need to do all that 'which conversation is this' checking.
--
Ticket URL: <http://developer.pidgin.im/ticket/96#comment:8>
Pidgin <http://pidgin.im>
Pidgin
More information about the Tracker
mailing list