[Pidgin] #725: Logging Embedded Images

[Pidgin]

#725: Logging Embedded Images
------------------------+---------------------------------------------------
  Reporter:  dave1g     |       Owner:                    
      Type:  patch      |      Status:  new               
  Priority:  minor      |   Milestone:                    
 Component:  libpurple  |     Version:  2.0               
Resolution:             |    Keywords:  log logging images
   Pending:  0          |  
------------------------+---------------------------------------------------
Comment (by rlaager):

 A few things:

  1. Does purple_prepare_image_messages_for_logging() need to be public? If
 it's not called anywhere else, I don't see a reason.
  2. This needs to use purple_imgstore_ref_by_id() and unref_by_id()
 instead of ref() and unref().
  3. The indentation does not match our existing code. We use tabs for
 indentation, and the braces line up with the while/if/etc.
  4. This should name files by a hash of their contents, instead of using
 their original filename. This way, we won't end up with a bunch of copies
 of the same custom emoticons, for example. There's code in
 libpurple/buddyicon.c that can be used for this. We may want a function in
 libpurple/util.c to avoid duplication.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/725#comment:2>
Pidgin <http://pidgin.im>
Pidgin