[Pidgin] #460: Choose buddy icon should resize my icon for XMPP.

[Pidgin]

#460: Choose buddy icon should resize my icon for XMPP.
------------------------------+---------------------------------------------
  Reporter:  doconnor         |       Owner:  seanegan
      Type:  enhancement      |      Status:  new     
  Priority:  minor            |   Milestone:          
 Component:  winpidgin (gtk)  |     Version:  2.0     
Resolution:                   |    Keywords:          
   Pending:  0                |  
------------------------------+---------------------------------------------
Comment (by chckens):

 Replying to [comment:6 andre.dahlqvist]:
 > chckens: My testing does not give the same result as you for XMPP buddy
 icons:
 >
 >  * Pidgin accepts a buddy icon with a file size of 8151 bytes, and
 resolution 64x61.

 8KB = 8192 bytes, so it meets the file size requirements and resolution
 requirements, hence accepted.

 >  * Pidgin rejects a buddy icon with a file size of 6066 bytes, and
 resolution 120x90.

 Intuitively, the file size should shrink when the image is scaled down.
 Although, if this image was a JPG file to start with it would certainly
 account for the jump in file size, as Pidgin converts to PNG when scaling.
 Speculating a little further, perhaps an 8-bit PNG might also increase its
 filesize if Pidgin were to scale it and output a 32-bit PNG.

 Anyhow, if you open the debug window when you attempt to set this icon,
 I'm confident you'll see  messages along the lines of "'foo.png' was
 converted to an image which is 12825 bytes, but the maximum icon size for
 XMPP is 8191 bytes" ... if the image isn't being converted and the
 filesize is still identical then I'd believe that there's a different
 problem.

 > If I manually resize the image used in the second test to a resolution
 of 96x72, Pidgin accepts it.

 Yes, if the image is in a file format allowed by XMPP *and* is the correct
 dimensions, Pidgin will not attempt to convert/scale it. However, the icon
 still will not be set if it breaches the filesize restriction.

 I might have a go at writing a patch to improve the behaviour of the
 scaling if I get some free time, but that might not be for a couple of
 weeks.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/460#comment:7>
Pidgin <http://pidgin.im>
Pidgin