[Pidgin] #1117: Bonjour for win32 support

Pidgin trac at pidgin.im
Sat May 19 00:13:56 EDT 2007


#1117: Bonjour for win32 support
---------------------------+------------------------------------------------
 Reporter:  cdavies        |       Type:  enhancement
   Status:  new            |   Priority:  minor      
Component:  libpurple      |    Version:  2.0        
 Keywords:  bonjour win32  |    Pending:  0          
---------------------------+------------------------------------------------
 ''' This patch is not yet ready to apply - informational only comments and
 new patches will be added later. I'm basically looking for feedback on the
 approach I'm using at the moment, a final patch will probably be added
 next Thursday '''

 What I've done:

 * Added config.h defines USE_BONJOUR_HOWL and USE_BONJOUR_APPLE to select
 between the two implementations

 * Divided the Bonjour MDNS guts in to various files. mdns_common.[ch]
 presents an interface to the world, mdns_win32.[ch] and mdns_howl.[ch] are
 the two implementations. mdns_types.h is shared type information.

 * Written the win32 guts.

 What is still to be done:

 * Testing! I don't even know if this compiles on Unixen yet, and I won't
 know until next Thursday when I get back to a network I can test this out
 on. This is mainly why the patch isn't ready to apply.

 * Thinking about packaging. It's my *belief* that you can compile Bonjour
 in to the win32 version and distribute, and it'll just refuse to start any
 Bonjour account on machines that don't have the server installed. Again, I
 need to confirm this with testing.

 * Make it compile against vanilla Bonjour SDK for windows. Bonjour for
 windows is broken in so many ways, it beggars belief. One of them is a
 whole bunch of silliness in the header. I'll need to do some undef work to
 make it compile correctly.

 * Document the new compile time dependency on Bonjour SDK.

 Things that will be done separately:

 * Fix the memory leaks and other silliness in the howl implementation. I
 haven't touched them in this patch.

 * Add buddy icon support for the Bonjour plugin

 Legality:

 The Bonjour client lib is licensed under the three clause (modified) BSD
 licence, and so is fine to link in to a GPL program. See
 http://developer.apple.com/networking/bonjour/ for details.

 ''' So, if a regular developer can have a quick glance of the v1 patch and
 give some feedback, I'd be grateful '''

-- 
Ticket URL: <http://developer.pidgin.im/ticket/1117>
Pidgin <http://pidgin.im>
Pidgin


More information about the Tracker mailing list