[Pidgin] #1331: MSNP14 cannot see MSN users registered with a yahoo mail address

[Pidgin]

#1331: MSNP14 cannot see MSN users registered with a yahoo mail address
-----------------------+----------------------------------------------------
 Reporter:  sbriglie   |       Type:  defect
   Status:  new        |   Priority:  minor 
Component:  libpurple  |    Version:  2.0.1 
 Keywords:             |    Pending:  0     
-----------------------+----------------------------------------------------
 Hi, I am using the MSNP14 branch of pidgin. I noticed that I had a MSN
 buddy who was online (I checked with other clients) but I always saw this
 buddy offline with pidgin.
 Today I decided to try and find out why and I came out with this
 explanation: the buddy has a MSN passport with a yahoo mail address. In
 fact in file libpurple/protocols/msn/notification.c lines 635-640 look
 like:

 {{{
  if(g_strrstr(domain,"yahoo") != NULL){
                 type_str = g_strdup_printf("32");
         }else{
                 /*passport*/
                 type_str = g_strdup_printf("1");
         }
 }}}
 It seems like MSN users with a yahoo domain are treated differently. I
 think that this could be caused by the faulty assumption that a user with
 a yahoo domain is a Yahoo messenger user, while in fact it is perfectly
 possible to create a MSN passport with a yahoo mail address. I know my
 buddy has such.
 Just for testing I changed yahoo to $provider in line 635 and all my MSN
 buddies with a passport registered with an email address from $provider
 changed from online to offline.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/1331>
Pidgin <http://pidgin.im>
Pidgin