[Pidgin] #1332: Convert gtkprefs option menus, as well as protocol and account option menus to combo boxes

[Pidgin]

#1332: Convert gtkprefs option menus, as well as protocol and account option menus
to combo boxes
---------------------------+------------------------------------------------
  Reporter:  nix_nix       |       Owner:       
      Type:  patch         |      Status:  new  
  Priority:  minor         |   Milestone:       
 Component:  pidgin (gtk)  |     Version:  2.0.1
Resolution:                |    Keywords:       
   Pending:  0             |  
---------------------------+------------------------------------------------
Comment (by nix_nix):

 Replying to [comment:9 sadrul]:
 > Replying to [comment:7 nix_nix]:
 > > Again, assuming that plugins do not expect to directly manipulate the
 GtkMenu, we could add an API like pidgin_account_option_menu_get_selected
 called pidgin_protocol_option_menu_get_selected to get rid of the need for
 "protocol" and the GtkWidget *item ... argument altogether.
 >
 > Yes, and that would require changes in the plugin code, which still
 bumps the major version.

 No, it wouldn't. We ''do'' the ugly hack, ''and'' we provide the new API
 (which only bumps the minor version). Then, we remove the ugly hack when
 we bump the major version.

 > "looks 1e6 times better" is not necessarily a good enough reason to
 break plugins, or introduce ugly hacks.

 No, but using GtkOptionMenu (and GtkCombo, which I haven't even touched
 yet) in GTK+-2.10 oughta be.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/1332#comment:11>
Pidgin <http://pidgin.im>
Pidgin