[Pidgin] #1317: Nicer "Smiley Themes" preferences tab
Pidgin
trac at pidgin.im
Mon May 28 19:31:31 EDT 2007
#1317: Nicer "Smiley Themes" preferences tab
---------------------------+------------------------------------------------
Reporter: lithium | Owner:
Type: enhancement | Status: new
Priority: minor | Milestone:
Component: pidgin (gtk) | Version: 2.0.1
Resolution: | Keywords:
Pending: 0 |
---------------------------+------------------------------------------------
Comment (by nix_nix):
Notes about the patch:
The functionality of the "Add" button is pretty trivial, because adding
themes is old functionality.
Removing a smiley theme is done by destroying all smiley themes and re-
loading all of them from disk using the pidgin_themes_smiley_theme_probe()
function.
For pidgin 2.1.0, we should add a public API like
pidgin_themes_smiley_theme_destroy which will remove a given theme from
gtkthemes.c:smiley_themes (and maybe even remove the files from disk -
currently done in gtkprefs.c).
I have also not fully explored the ramifications of destroying
smiley_theme structures. The struct smiley_theme * pointers contained in
the gtkthemes.c:smiley_themes GSList might appear in some other places, in
which case they'll become stale after such a reload. I hope this is not
the case.
--
Ticket URL: <http://developer.pidgin.im/ticket/1317#comment:3>
Pidgin <http://pidgin.im>
Pidgin
More information about the Tracker
mailing list