[Pidgin] #1344: fix for some build warnings

[Pidgin]

#1344: fix for some build warnings
----------------------------+-----------------------------------------------
  Reporter:  o_sukhodolsky  |       Owner:  rlaager 
      Type:  patch          |      Status:  assigned
  Priority:  minor          |   Milestone:  2.0.2   
 Component:  pidgin (gtk)   |     Version:  2.0.1   
Resolution:                 |    Keywords:          
   Pending:  0              |  
----------------------------+-----------------------------------------------
Comment (by o_sukhodolsky):

 Replying to [comment:4 rlaager]:
 >  1. In log_reader.c, you've unmarked strings for translation. Here's one
 of at least two. Why?
 {{{
 307     -                                               line = _("User is
 offline.");
 308     +                                               line = "User is
 offline.";
 }}}

 well, I've remove _() only in the lines where you have tried to assign
 const string to non-const
 one) and compilers warns about this).  As far as I can see these are the
 only such places in
 2.0.1 sources.

 >  2. How did you arrive at the caddr_t type?
 {{{
 678     -    void               *z_message;
 679     +    caddr_t            z_message;
 }}}

 I've got this from definition of the same structure in Zephyr's sources.

 >  3. Where you able to test the Zephyr changes?

 Well, I do not use Zephyr, so I an not test this :( but caddr_t is just
 char* and AFAIK pointer arithmetic with void* handled the same way as with
 char*.
 As for changes which check return value of read()/write() then I have no
 idea how to test this since it is hard to get errors in these function.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/1344#comment:7>
Pidgin <http://pidgin.im>
Pidgin