[Pidgin] #1317: Nicer "Smiley Themes" preferences tab
Pidgin
trac at pidgin.im
Tue May 29 19:02:57 EDT 2007
#1317: Nicer "Smiley Themes" preferences tab
---------------------------+------------------------------------------------
Reporter: lithium | Owner:
Type: enhancement | Status: new
Priority: minor | Milestone:
Component: pidgin (gtk) | Version: 2.0.1
Resolution: | Keywords:
Pending: 0 |
---------------------------+------------------------------------------------
Comment (by nix_nix):
Replying to [comment:4 rlaager]:
> You can assume this is going to go in for a minor release and do any new
functions right off the bat.
Oops ... I re-implemented the patch so that it doesn't need new API. It
will only remove those themes whose theme file is no longer on disk. I can
create a second version of the patch that does introduce new API (and is a
bit cleaner because of it) so that it's also ready for the minor version.
> For the UNTESTED stuff... you want g_unlink() and g_rmdir(), which you
can use on any platform without #ifdefs. It's only available in glib 2.6+,
but we've dealt with that (for *nix) already in internal.h. Since we ship
glib on win32, we know it's always at least 2.6.
OK. Done.
> Do we really want to reprobe all of them? Could we have the probe
function only probe new themes? That's what we do for plugins, I believe.
I've changed the function pidgin_smiley_themes_remove_all() to
pidgin_smiley_themes_remove_non_existing(). So, the _probe() function
first removes themes whose disk files no longer exist, and then it adds
new themes as before.
> I forget... Does the patch deal with the text at the top of the window?
It does now :o)
I've also added some code to retain the currently used smiley theme as the
selected item in the theme list when themes are added. However, if you
remove a theme, the selection will jump to the "none" theme. That way, we
don't get into a situation where no theme is selected.
--
Ticket URL: <http://developer.pidgin.im/ticket/1317#comment:5>
Pidgin <http://pidgin.im>
Pidgin
More information about the Tracker
mailing list