[Pidgin] #1344: fix for some build warnings

Pidgin trac at pidgin.im
Wed May 30 00:24:24 EDT 2007


#1344: fix for some build warnings
----------------------------+-----------------------------------------------
  Reporter:  o_sukhodolsky  |       Owner:  rlaager 
      Type:  patch          |      Status:  assigned
  Priority:  minor          |   Milestone:  2.0.2   
 Component:  pidgin (gtk)   |     Version:  2.0.1   
Resolution:                 |    Keywords:          
   Pending:  0              |  
----------------------------+-----------------------------------------------
Comment (by o_sukhodolsky):

 Replying to [comment:16 rlaager]:
 > I'm not seeing an error in libpurple/plugins/tcl/tcl_signals.c. What
 error are you getting? Apparently that Tcl call was being defined as a
 macro without braces or something?

 here is what the compiler says:

 ../../../../libpurple/plugins/tcl/tcl_signals.c: In function
 'tcl_signal_handler_free':
 ../../../../libpurple/plugins/tcl/tcl_signals.c:51: warning: suggest
 explicit braces to avoid ambiguous 'else'

 the only way to fix that I've found is add curly braces for this if.

 > Also, in the future... separate smaller patches are easier for me to
 work with.

 ok. I will.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/1344#comment:19>
Pidgin <http://pidgin.im>
Pidgin


More information about the Tracker mailing list