[Pidgin] #1344: fix for some build warnings

Pidgin trac at pidgin.im
Wed May 30 02:44:21 EDT 2007


#1344: fix for some build warnings
----------------------------+-----------------------------------------------
  Reporter:  o_sukhodolsky  |       Owner:  rlaager 
      Type:  patch          |      Status:  assigned
  Priority:  minor          |   Milestone:  2.0.2   
 Component:  pidgin (gtk)   |     Version:  2.0.1   
Resolution:                 |    Keywords:          
   Pending:  0              |  
----------------------------+-----------------------------------------------
Comment (by o_sukhodolsky):

 Replying to [comment:25 rlaager]:
 > You have a "File trabsfer" in the patch. Also, there is still some (1 ==
 foo) stuff. Additionally, you still have this:

 {{{
 +  result = fwrite(data->data, 1, data->len, fp);
 +  g_return_if_fail(result == data->len);
 }}}

 I left this because imho the only thing we should do here is log something
 or assert.

 > I believe I've gotten everything but the [f]read/[f]write() changes
 committed. I look forward to your response regarding
 purple_util_write_data_to_file().

 I will think about this tonight :)

 btw is there way to get sources from your repository to have them up-to-
 date?  I have not found any pointers on your site :(

-- 
Ticket URL: <http://developer.pidgin.im/ticket/1344#comment:26>
Pidgin <http://pidgin.im>
Pidgin


More information about the Tracker mailing list