[Pidgin] #1405: Tab completion segfault - caused by strcmp(..., NULL)

[Pidgin]

#1405: Tab completion segfault - caused by strcmp(..., NULL)
--------------------------+-------------------------------------------------
 Reporter:  resiak        |       Owner:       
     Type:  defect        |      Status:  new  
 Priority:  minor         |   Milestone:       
Component:  pidgin (gtk)  |     Version:  2.0.1
 Keywords:                |     Pending:  0    
--------------------------+-------------------------------------------------
 Good Pidgin-folk,

 I just encountered an (unreproducible) segfault when tab-completing in an
 IRC channel, at gtkconv.c:3760 (`if (strcmp(name, alias))`).  Apparently
 the preceeding `gtk_tree_model_get` stuffed `NULL` into `alias`, and thus
 the strcmp explodes.

 I could have sworn that a `g_strcmp` exists that does `NULL` checks, but
 apparently it does not.  I guess that `if (name && alias && strcmp(name,
 alias))` is good enough, but I don't have time to go checking whether
 `gtk_tree_model_get` on the userlist model is ever meant to return `NULL`
 aliases.

 Backtrace attached.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/1405>
Pidgin <http://pidgin.im>
Pidgin