[Pidgin] #3730: Implementation for file-sending through proxies

[Pidgin]

#3730: Implementation for file-sending through proxies
--------------------+-------------------------------------------------------
  Reporter:  galt   |       Owner:  nwalp              
      Type:  patch  |      Status:  new                
  Priority:  minor  |   Milestone:                     
 Component:  XMPP   |     Version:  2.2.2              
Resolution:         |    Keywords:  file,transfer,proxy
   Pending:  0      |  
--------------------+-------------------------------------------------------
Comment (by evands):

 Great!  I haven't had a chance to test your patch, but reading through it
 I have 2 comments:
  1. Watch your coding style; we try to keep spacing and indentation
 consistent.  Specifically, I noticed that some variable declarations were
 like {{{GList * temp;}}} rather than {{{GList *temp;}}}
  2. Should the various {{{if (!test) return;}}} calls, such as {{{if(!jsx)
 return;}}}, be g_return_if_fail() instead?  g_return_if_fail() should be
 used if it is an error for the test to be false; a simple if() is
 appropriate if the normal/expected course of events may lead a false test.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/3730#comment:1>
Pidgin <http://pidgin.im>
Pidgin