[Pidgin] #3730: Implementation for file-sending through proxies
Pidgin
trac at pidgin.im
Fri Nov 2 03:18:39 EDT 2007
#3730: Implementation for file-sending through proxies
--------------------+-------------------------------------------------------
Reporter: galt | Owner: nwalp
Type: patch | Status: new
Priority: minor | Milestone:
Component: XMPP | Version: 2.2.2
Resolution: | Keywords: file,transfer,proxy
Pending: 0 |
--------------------+-------------------------------------------------------
Comment (by galt):
OK, so I looked over it. Regarding the comments:
1. I will post a modified patch to change the pointer declaration spacing,
a string, and another small inconsistency.
2. I don't think any of those tests indicates a failure. if(!jsx) is
important because it is (technically) possible for a transfer to finish
before the streamhost-used is received. I actually ran into this problem
while testing with both clients on the same machine. So if jsx is NULL,
that's OK, nothing needs to be done.
3. There was one place where I forgot to free the streamhosts list, I'll
fix that too. I'm not sure that part is even needed, it depends on the
issue i asked about in the previous post. As to the streamhosts that are
being allocated and the definition of bs_streamhost... Well I'm not the
one who defined it :) And there shouldn't be a need to add code to free
these elements, since the patch only modifies the list, and I'm sure it's
already being freed in previously existing code. The code in the patch
does free all elements and the list itself before assigning a new list and
dropping the old pointer.
So I'll post a slightly updated version very soon. If you still have
questions don't hesitate to ask.
This works very well for me btw, so well that I think my next patch may be
to add optional upload caps to file transfers ;-)
--
Ticket URL: <http://developer.pidgin.im/ticket/3730#comment:4>
Pidgin <http://pidgin.im>
Pidgin
More information about the Tracker
mailing list