[Pidgin] #480: Windows socket error when resuming from standby with beta7
Pidgin
trac at pidgin.im
Sun Nov 11 16:02:10 EST 2007
#480: Windows socket error when resuming from standby with beta7
------------------------------+---------------------------------------------
Reporter: KyroMaster | Owner: datallah
Type: defect | Status: reopened
Priority: minor | Milestone:
Component: winpidgin (gtk) | Version: 2.0
Resolution: | Keywords:
Pending: 0 |
------------------------------+---------------------------------------------
Comment (by imiganai):
Replying to [comment:22 phroggie]:
> The attached [attachment:win32_handle_standby.diff patch] is one way of
handling this. The other would be to add a few accessor functions to
gtkconn.c (which would have probably been best). Any ideas / patches to
simplify this?
>
> We leave a 1 second timer to give gtkconn.c time to notice that it may
have lost it's network link (think wifi, not signaled dead until after
resume). g_idle_add was too quick, and 500 ms was plenty of time on a slow
vista laptop, so 1000 ms is probably too much time, but sane. If the
network link was in fact lost, gtkconn will handle reconnection.
Otherwise, we have to handle it manually. purple_accounts_get_all_active
takes care of the dirty work on figuring out what gets reconnected.
Looks great from a windows standpoint; and what with all of the other
things that go on when one resumes from standby, I can imagine the 1
second seeming instantaneous to the user.
What would adding to gtkconn.c involve? Probably not a great idea to toss
platform-specific code in there, but if you stick in a few helper
functions that could be used for any operating system resuming from
standby, that'd be awesome. ...is this even an issue on *nix?
Otherwise, your solution is probably awesome. Thanks!
--
Ticket URL: <http://developer.pidgin.im/ticket/480#comment:23>
Pidgin <http://pidgin.im>
Pidgin
More information about the Tracker
mailing list