[Pidgin] #3989: PidginScrollBook has a broken GtkContainer implementation

[Pidgin]

#3989: PidginScrollBook has a broken GtkContainer implementation
---------------------------+------------------------------------------------
  Reporter:  resiak        |       Owner:       
      Type:  defect        |      Status:  new  
  Priority:  minor         |   Milestone:       
 Component:  pidgin (gtk)  |     Version:  2.2.2
Resolution:                |    Keywords:       
   Pending:  0             |  
---------------------------+------------------------------------------------
Comment (by sadrul):

 This seems to work for gtk_container_get_children:
 {{{
 #
 # old_revision [bebf7d7e6a79c7790d2a56820eecfce4e8f2cd9e]
 #
 # patch "pidgin/gtkscrollbook.c"
 #  from [5a53af6d62a64b4ca8b24af84decf0161fb1dbcc]
 #    to [0500ca880db046b93f6b742550970a11a833d203]
 #
 ============================================================
 --- pidgin/gtkscrollbook.c      5a53af6d62a64b4ca8b24af84decf0161fb1dbcc
 +++ pidgin/gtkscrollbook.c      0500ca880db046b93f6b742550970a11a833d203
 @@ -204,16 +204,9 @@ pidgin_scroll_book_forall(GtkContainer *
         if (include_internals) {
                 (*callback)(scroll_book->hbox, callback_data);
                 (*callback)(scroll_book->notebook, callback_data);
 +       } else {
 +
 gtk_container_foreach(GTK_CONTAINER(scroll_book->notebook), callback,
 callback_data);
         }
 -
 -       children = scroll_book->children;
 -
 -       while (children) {
 -               GtkWidget *child;
 -               child = children->data;
 -               children = children->next;
 -               (*callback)(child, callback_data);
 -       }
  }

  static void
 }}}
 I can't really explain why, though ;)

-- 
Ticket URL: <http://developer.pidgin.im/ticket/3989#comment:2>
Pidgin <http://pidgin.im>
Pidgin