[Pidgin] #4137: Oscar Chat Joining failure

[Pidgin]

#4137: Oscar Chat Joining failure
-----------------------+----------------------------------------------------
Reporter:  JensenDied  |       Owner:  MarkDoliner                          
    Type:  defect      |      Status:  new                                  
Priority:  minor       |   Component:  AIM                                  
 Version:  2.3.0       |    Keywords:  oscar libpurple oscar_join_chat patch
 Pending:  0           |  
-----------------------+----------------------------------------------------
 The oscar_join_chat function in libpurple/protocols/oscar/oscar.c
 checks to see if name has a valid result from g_hash_table_lookup however
 exchange is never checked

 snip
 {{{
         name = g_hash_table_lookup(data, "room");
         exchange = g_hash_table_lookup(data, "exchange");

         if ((name == NULL) || (*name == '\0')) {
 }}}

 The attached patch does use a new string due since it is related to
 another varible.[[br]]
 It might also be reasonable to simply add an additional or condition since
 exchange can be null when name is still valid by the current check. ex:
 irc style channel names cause a crash currently.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/4137>
Pidgin <http://pidgin.im>
Pidgin