[Pidgin] #3489: Fix crash due to gtkconv->{win, make_sound} dereference without gtkconv NULL-check

Pidgin trac at pidgin.im
Fri Oct 12 07:05:20 EDT 2007


#3489: Fix crash due to gtkconv->{win,make_sound} dereference without gtkconv
NULL-check
---------------------------+------------------------------------------------
  Reporter:  nix_nix       |       Owner:  sadrul  
      Type:  patch         |      Status:  assigned
  Priority:  minor         |   Milestone:          
 Component:  pidgin (gtk)  |     Version:  2.2.1   
Resolution:                |    Keywords:          
   Pending:  0             |  
---------------------------+------------------------------------------------
Changes (by sadrul):

  * owner:  => sadrul
  * status:  new => assigned

Comment:

 The removal of dead-code (win) looks good.

 For the crash on NULL gtkconv, the
 {{{PIDGIN_IS_PIDGIN_CONVERSATION(conv)}}} should catch that a few lines
 above. Do you know why that isn't happening?

-- 
Ticket URL: <http://developer.pidgin.im/ticket/3489#comment:1>
Pidgin <http://pidgin.im>
Pidgin


More information about the Tracker mailing list