[Pidgin] #3510: Generic patch: Cannot send jpeg file to a yahoo buddy

[Pidgin]

#3510: Generic patch: Cannot send jpeg file to a yahoo buddy
---------------------------+------------------------------------------------
  Reporter:  dbeusee       |       Owner:        
      Type:  patch         |      Status:  closed
  Priority:  minor         |   Milestone:        
 Component:  pidgin (gtk)  |     Version:  2.2.1 
Resolution:  fixed         |    Keywords:        
   Pending:  0             |  
---------------------------+------------------------------------------------
Changes (by sadrul):

  * status:  new => closed
  * resolution:  => fixed

Old description:

> when I drag an image to a buddy, I only have the option to set as buddy
> icon.  I cannot send the file.
>
> The fix is simple:
>
> $ diff /src/sourceforge/pidgin-2.2.1/pidgin/gtkutils.c gtkutils.c
> 1514c1514
> <                       gboolean ft = FALSE, im = FALSE;
> ---
> >                       gboolean ft = TRUE, im = FALSE;
>
> Explanation:
> Some protocol plugins might not have prpl_info->can_receive_file set, so
> we should just send the file anyway.  That is done in the non-image case
> unconditionally.

New description:

 when I drag an image to a buddy, I only have the option to set as buddy
 icon.  I cannot send the file.

 The fix is simple:
 {{{
 $ diff /src/sourceforge/pidgin-2.2.1/pidgin/gtkutils.c gtkutils.c
 1514c1514
 <                       gboolean ft = FALSE, im = FALSE;
 ---
 >                       gboolean ft = TRUE, im = FALSE;
 }}}
 Explanation:
 Some protocol plugins might not have prpl_info->can_receive_file set, so
 we should just send the file anyway.  That is done in the non-image case
 unconditionally.

Comment:

 Thanks for the patch. But instead of blindly setting {{{ft = TRUE}}}, it's
 better to confirm that the prpl actually supports file-transfer.

 Also, http://developer.pidgin.im/wiki/TipsForPatchSubmissions

-- 
Ticket URL: <http://developer.pidgin.im/ticket/3510#comment:1>
Pidgin <http://pidgin.im>
Pidgin