[Pidgin] #3550: PurpleLog::time is wrong

[Pidgin]

#3550: PurpleLog::time is wrong
---------------------------+------------------------------------------------
  Reporter:  xpertbg       |       Owner:       
      Type:  defect        |      Status:  new  
  Priority:  minor         |   Milestone:       
 Component:  pidgin (gtk)  |     Version:  2.2.1
Resolution:                |    Keywords:       
   Pending:  1             |  
---------------------------+------------------------------------------------
Changes (by rlaager):

  * pending:  0 => 1

Comment:

 Replying to [comment:7 xpertbg]:
 > I see 2 problems here:
 >  * there is thread unsafe code in pidgin (which I copied thinking it is
 ok)

 What did you copy? I can't find this code you're talking about.

 I think you're confused about your terminology here. None of our code is
 intended to be thread safe. You can't use libpurple from multiple threads
 unless you do your own locking.

 Are you really using purple_date_format_full() in a thread? Your code
 samples show you calling it twice from one line of code. This isn't going
 to work properly because purple_date_format_full() calls
 purple_utf8_strftime() which uses a static buffer.

 >  * PurpleLog::time is one hour wrong

-- 
Ticket URL: <http://developer.pidgin.im/ticket/3550#comment:8>
Pidgin <http://pidgin.im>
Pidgin