[Pidgin] #3553: Code duplication reduction in gtkblist.c

Pidgin trac at pidgin.im
Sun Oct 14 19:20:18 EDT 2007


#3553: Code duplication reduction in gtkblist.c
---------------------------+------------------------------------------------
  Reporter:  nix_nix       |       Owner:       
      Type:  patch         |      Status:  new  
  Priority:  minor         |   Milestone:       
 Component:  pidgin (gtk)  |     Version:  2.2.1
Resolution:                |    Keywords:       
   Pending:  0             |  
---------------------------+------------------------------------------------
Comment (by nix_nix):

 Despite having removed a lot of duplicate code, I may have missed or
 misinterpreted differences in the semantics of the various functions I
 unified. Same goes for the many copies of gtk_hbox_new(), ...,
 gtk_label_new(), ... Some of them may have been slightly different from
 others.

 We should make sure that I haven't accidentally destroyed any behaviour
 that was there before.

 I'll merge this patch with my downstream changes, and I'll use the
 resulting Pidgin over the course of the next few days.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/3553#comment:1>
Pidgin <http://pidgin.im>
Pidgin


More information about the Tracker mailing list