[Pidgin] #2913: A patch for SMS support in ICQ

[Pidgin]

#2913: A patch for SMS support in ICQ
---------------------------+------------------------------------------------
  Reporter:  db42          |       Owner:  MarkDoliner
      Type:  patch         |      Status:  closed     
  Priority:  minor         |   Milestone:             
 Component:  pidgin (gtk)  |     Version:  2.1.1      
Resolution:  fixed         |    Keywords:             
   Pending:  0             |  
---------------------------+------------------------------------------------
Changes (by MarkDoliner):

  * status:  assigned => closed
  * resolution:  => fixed

Comment:

 Committed!  If you let me know your real first and last name I can add you
 to our COPYRIGHT file.  Great patch, thanks.  A few small nits:

 * Don't use // comments, we try to be compatible with ANSI C 89/90.

 * In incomingim_chan4() in oscar.c, xmlnode_get_child() returns a pointer
 into the xml tree.  It does not return a duplicate node, so it should not
 be free'd when no longer needed.  However, xmlnode_from_str() allocates a
 whole tree and the result there DOES need to be free'd.  My cell phone is
 a US number so I can't test the changes, but PLEASE PLEASE PLEASE test it
 and make sure I didn't break anything.

 Aside from that, nicely done!

-- 
Ticket URL: <http://developer.pidgin.im/ticket/2913#comment:3>
Pidgin <http://pidgin.im>
Pidgin