[Pidgin] #2858: Pidgin doesn't put newlines in files saved with "Conversation>Save As"

[Pidgin]

#2858: Pidgin doesn't put newlines in files saved with "Conversation>Save As"
---------------------------+------------------------------------------------
  Reporter:  rageboy       |       Owner:  seanegan
      Type:  patch         |      Status:  reopened
  Priority:  minor         |   Milestone:  2.2.0   
 Component:  pidgin (gtk)  |     Version:  2.1.1   
Resolution:                |    Keywords:          
   Pending:  0             |  
---------------------------+------------------------------------------------
Changes (by kstange):

  * status:  closed => reopened
  * resolution:  fixed =>

Comment:

 Unfortunately this patch is not a complete solution, so I've reverted the
 change.  Adding \n into the HTML in addition to the <BR> causes us to get
 "\n\n" on conversion back, which in turn is "<br>\n<br>\n" the next time,
 and so on.

 The solution will have to make a change in at least one other place in the
 IMHTML code in order to ensure that when we read in HTML code and convert
 it to our IMHTML format, we correctly ignore "non-printable" line breaks
 without failing to account for "printable" line breaks, which in terms of
 the internal IMHTML format has traditionally been all of them.

 One possible solution would be to parse out the necessary line breaks and
 insert them into the log files in the logging function "html_logger_write"
 or in "purple_markup_html_to_xhtml" (assuming there aren't any cases where
 this causes issues)  The "html_logger_read" function already takes care of
 ignoring "\n" when reading in logs, but most the the rest of Pidgin does
 not ignore "\n" so we want to add these line breaks as close to writing
 out the logs as is reasonable.

 I would dig further, but I'm too tired right now.  If someone else doesn't
 tackle this first, perhaps I will.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/2858#comment:6>
Pidgin <http://pidgin.im>
Pidgin