[Pidgin] #2990: MSNP14: #ifdef HAVE_TM_GMTOFF in oim.c:450

[Pidgin]

#2990: MSNP14: #ifdef HAVE_TM_GMTOFF in oim.c:450
-----------------------+----------------------------------------------------
 Reporter:  geddeth    |       Type:  defect
   Status:  new        |   Priority:  minor 
Component:  libpurple  |    Version:        
 Keywords:  msnp14     |    Pending:  0     
-----------------------+----------------------------------------------------
 In current MTN of im.pidgin.cpw.khc.msnp14, in
 libpurple/protocols/msn/oim.c, line 450:
 - #if HAVE_TIMEZONE
 + #ifdef HAVE_TM_GMTOFF

 This is cross-compiling for win32 on a Debian testing box. It compiles
 with this change - I have no idea how it runs, though. Ask for more info.

 G.

 {{{
 (11:34:10 PM) Geddeth: datallah, do you know if the msnp14 branch compiles
 for win32 right now?
 (11:34:28 PM) datallah: Geddeth: I haven't tried lately, I think it does
 though.
 (11:34:31 PM) Geddeth: as in: should it compile?
 (11:34:36 PM) Geddeth: ok
 (11:34:56 PM) datallah: does it not?
 (11:34:59 PM) Geddeth: I've been using your instructions for cross-
 compiling on Debian for a while - working great.
 (11:35:07 PM) datallah: cool
 (11:35:37 PM) Geddeth: With the msnp14 branch, I'm right now getting a
 "structure has no member named `tm_gmtoff'"-error, which I suspect is very
 common ..
 (11:35:51 PM) Geddeth: just can't work out what I'm missing. I thought it
 was gnulib, but apparently not.
 (11:36:53 PM) datallah: you don't need anything for that
 (11:37:42 PM) datallah: there should be an #ifdef HAVE_TM_GMTOFF around it
 (11:37:49 PM) Geddeth: #if HAVE_TIMEZONE
 (11:38:09 PM) Geddeth: which apparently evaluates to true on my system.
 (11:39:15 PM) rlaager: no, the define is HAVE_TM_GMTOFF
 (11:39:37 PM) rlaager: If the code is using tm_gmtoff somewhere that isn't
 wrapped by HAVE_TM_GMTOFF, then the code is wrong.
 (11:40:11 PM) rlaager: But keep in mind that you can't just slap in #ifdef
 in and expect it to work properly. It'll take more code changes if someone
 needs the GMT offset.
 (11:41:20 PM) Geddeth: ok, thanks - that seems to get things rolling
 again.
 (11:41:59 PM) Geddeth: so cross-compiling the msnp14 branch does also
 work, in fact.
 (11:42:04 PM) Geddeth: I'll throw this onto khc, eh?
 (11:42:09 PM) Geddeth: *on to
 (11:42:12 PM) Geddeth: ;)
 (11:43:04 PM) rlaager: file a ticket
 }}}

-- 
Ticket URL: <http://developer.pidgin.im/ticket/2990>
Pidgin <http://pidgin.im>
Pidgin