[Pidgin] #3154: Threading code in jabber makes no sense

[Pidgin]

#3154: Threading code in jabber makes no sense
---------------------------+------------------------------------------------
  Reporter:  arivanov      |       Owner:       
      Type:  defect        |      Status:  new  
  Priority:  minor         |   Milestone:       
 Component:  pidgin (gtk)  |     Version:  2.2.0
Resolution:                |    Keywords:       
   Pending:  0             |  
---------------------------+------------------------------------------------
Comment (by deryni):

 Correct, that code does in fact make no sense and I have had a change to
 it locally for some weeks now but as I don't talk to anyone on XMPP that
 uses a client that handles threading in any real way I have been unable to
 test it and therefore unwilling to commit it.

 The change is to make the code read:
     if (jm->thread_id) {
         g_free(jbr->thread_id);
         jbr->thread_id = g_strdup(jm->thread_id);
     }

 but like I said I haven't tested that at all beyond the fact that it
 compiles and I am not really at all familiar with the thread code in
 pidgin. I do believe that pidgin is also not following the best practices
 for threads as described in XEP-0201 in some ways but haven't had time to
 look into it more than that.

 Feel free to test my change and report back and/or to work on fixing up
 the thread code and submit patches.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/3154#comment:1>
Pidgin <http://pidgin.im>
Pidgin