[Pidgin] #3281: msimppl leaks memory in statstring, username, key_context, storing user info, user, MsimMessage dictionary parsing

[Pidgin]

#3281: msimppl leaks memory in statstring, username, key_context, storing user
info, user, MsimMessage dictionary parsing
----------------------+-----------------------------------------------------
  Reporter:  jeff     |       Owner:  jeff    
      Type:  defect   |      Status:  new     
  Priority:  major    |   Milestone:  2.2.1   
 Component:  MySpace  |     Version:  2.2.0   
Resolution:           |    Keywords:  msimprpl
   Pending:  0        |  
----------------------+-----------------------------------------------------
Old description:

> Fom Oliver Hardt:
>
> Hey,
>
> i profiled/memcheck'ed my application yesterday (which uses msimprpl)
> and i found a few memory leaks (or places that i think leak memory).
> I'm not familiar with the msimprpl code so i can't always tell if it's
> a valid problem or not but some of these are real leaks.
> Let me know if you want the whole valgrind trace/output or if i can
> help you in any other way.
>
> Cheers,
>
>  Oliver
>

>
> myspace.c:1073     leaks memory - statstring is a copy,
> purple_markup_strip_html() returns a           copy
>
> myspace.c:636        probably need g_free( username);
>
> myspace.c:452        key_context is never free'd ?
>
> user.c: 170 - 182     all the g_strdup'ing is suspicious, comes up in
> the memchecker way too often
>
> user.c:265              user is leaked later, probably in
>
> myspace.c:1862      user isn't free'd anywhere - memory from user.c:55 is
> lost
>
> message.c:1197      careless g_strdup'ing

New description:

 Hey,

 i profiled/memcheck'ed my application yesterday (which uses msimprpl)
 and i found a few memory leaks (or places that i think leak memory).
 I'm not familiar with the msimprpl code so i can't always tell if it's
 a valid problem or not but some of these are real leaks.
 Let me know if you want the whole valgrind trace/output or if i can
 help you in any other way.

 Cheers,

  Oliver



 myspace.c:1073     leaks memory - statstring is a copy,
 purple_markup_strip_html() returns a           copy

 myspace.c:636        probably need g_free( username);

 myspace.c:452        key_context is never free'd ?

 user.c: 170 - 182     all the g_strdup'ing is suspicious, comes up in
 the memchecker way too often

 user.c:265              user is leaked later, probably in

 myspace.c:1862      user isn't free'd anywhere - memory from user.c:55 is
 lost

 message.c:1197      careless g_strdup'ing

-- 
Ticket URL: <http://developer.pidgin.im/ticket/3281#comment:5>
Pidgin <http://pidgin.im>
Pidgin