[Pidgin] #5379: MSNP15 OIM not always working

[Pidgin]

#5379: MSNP15 OIM not always working
-------------------+--------------------------------------------------------
Reporter:  tomgr   |       Owner:  khc        
    Type:  defect  |      Status:  new        
Priority:  minor   |   Component:  MSN        
 Version:  2.4.1   |    Keywords:  MSNP15, OIM
 Pending:  0       |  
-------------------+--------------------------------------------------------
 When sending OIMs using the i.p.p.msnp15 branch they are not always sent
 succesfully. It appears that this is related to the length of a message as
 short ones almost always go through whereas longer ones are more hit and
 miss.

 Sample response when a message is not sent:
 {{{
 13:17:55: (Libpurple: MSNP14) send IM {<FONT FACE="Helvetica"><FONT
 COLOR="#2718ff"><B>aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa</B>}
 to tomgr at hotmail.co.uk
 13:17:55: (Libpurple: MSNP14) prepare to send offline Message
 13:17:55: (Libpurple: MSNP14) sending OIM:
 aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa
 13:17:55: (Libpurple: MSN OIM) encode OIM Message...
 13:17:55: (Libpurple: MSN OIM) encoded base64
 body:{YWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYQ==}
 13:17:55: (Libpurple: soap) POST /OimWS/oim.asmx HTTP/1.1
 SOAPAction: http://messenger.live.com/ws/2006/09/oim/Store2
 Content-Type:text/xml; charset=utf-8
 User-Agent: Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.1)
 Accept: */*
 Host: ows.messenger.msn.com
 Content-Length: 1974
 Connection: Keep-Alive
 Cache-Control: no-cache

 <soap:Envelope xmlns:xsi='http://www.w3.org/2001/XMLSchema-instance'
 xmlns:soap='http://schemas.xmlsoap.org/soap/envelope/'
 xmlns:xsd='http://www.w3.org/2001/XMLSchema'><soap:Header><From
 xmlns='http://messenger.msn.com/ws/2004/09/oim/' memberName='<SNIP>'
 friendlyName='=?utf-8?B?dGhvbWFzLmdpYnNvbnJvYmluc29uQGdtYWlsLmNvbQ==?='
 xml:lang='en-US' proxy='MSNMSGR' msnpVer='MSNP15' buildVer='8.5.1288'/><To
 xmlns='http://messenger.msn.com/ws/2004/09/oim/'
 memberName='<SNIP>'/><Ticket
 xmlns='http://messenger.msn.com/ws/2004/09/oim/' passport='<SNIP>'
 appid='PROD0119GSJUC$18'
 lockkey='e440b4b6bfbb57c57e81f41177d11e9e'/><Sequence
 xmlns='http://schemas.xmlsoap.org/ws/2003/03/rm'><Identifier
 xmlns='http://schemas.xmlsoap.org/ws/2002/07/utility'>http://messenger.msn.com</Identifier><MessageNumber>16</MessageNumber></Sequence></soap:Header><soap:Body><MessageType
 xmlns='http://messenger.msn.com/ws/2004/09/oim/'>text</MessageType><Content
 xmlns='http://messenger.msn.com/ws/2004/09/oim/'>MIME-Version: 1.0
 Content-Type: text/plain; charset=UTF-8
 Content-Transfer-Encoding: base64
 X-OIM-Message-Type: OfflineMessage
 X-OIM-Run-Id: {52B2A91B-6A76-9B50-6736-6F1B89FF838F}
 X-OIM-Sequence-Num: 16

 YWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYQ==</Content></soap:Body></soap:Envelope>
 13:17:55: Called write with no write_tag (read_tag 281 write_tag 0) for
 bab5cf0
 13:17:56: (Libpurple: soap) read 890 bytes
 13:17:56: (Libpurple: soap) current HTTP/1.1 500 Internal Server Error
 Date: Tue, 01 Apr 2008 12:17:56 GMT
 Server: Microsoft-IIS/6.0
 P3P:CP="BUS CUR CONo FIN IVDo ONL OUR PHY SAMo TELo"
 X-Powered-By: ASP.NET
 X-AspNet-Version: 2.0.50727
 Cache-Control: private
 Content-Type: text/xml; charset=utf-8
 Content-Length: 598

 <?xml version="1.0" encoding="utf-8"?><soap:Envelope
 xmlns:soap="http://schemas.xmlsoap.org/soap/envelope/"
 xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
 xmlns:xsd="http://www.w3.org/2001/XMLSchema"><soap:Header><Machine name
 ="BAYM-OW22" ver="13.20.1130.0"
 xmlns="http://messenger.msn.com/ws/2004/09/oim/"
 /></soap:Header><soap:Body><soap:Fault><faultcode
 xmlns:q0="http://messenger.msn.com/ws/2004/09/oim/">q0:InvalidContent</faultcode><faultstring>Exception
 of type 'System.Web.Services.Protocols.SoapException' was
 thrown.</faultstring><detail /></soap:Fault></soap:Body></soap:Envelope>
 13:17:56: (Libpurple: soap) ignoring malformed line: P3P:CP="BUS CUR CONo
 FIN IVDo ONL OUR PHY SAMo TELo"
 }}}

 More seriously, the error is never reported to the user - a patch is
 attached to fix this issue.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/5379>
Pidgin <http://pidgin.im>
Pidgin