[Pidgin] #5381: MSNP15 SOAP does not check if a pre-existing connection is still open when attempting to send

[Pidgin]

#5381: MSNP15 SOAP does not check if a pre-existing connection is still open when
attempting to send
-----------------------------------+----------------------------------------
 Reporter:  tomgr                  |       Type:  patch
   Status:  new                    |   Priority:  minor
Component:  libpurple              |    Version:  2.4.1
 Keywords:  MSNP15, SOAP, sending  |    Pending:  0    
-----------------------------------+----------------------------------------
 When sending a SOAP request the current code simply assumes that if the
 timeout has not destroyed the connection then it must still be connected.
 If it finds that it is not connected then the request is simply discarded
 (with no reporting to the user). This leads to problems with offline
 instant messages (in particular) and causes them not to be sent.

 The attached patch solves this by testing to see if the connection is
 currently open by trying to send the first lot of data. If it finds it is
 closed it reopens it and resends any messages.

 (There is still quite a considerable amount of work needed on the error
 reporting from the soap code, if anything goes wrong it seems to just
 ignore it. In particular if an error is encountered whilst reading from a
 socket it is just ignored.)

-- 
Ticket URL: <http://developer.pidgin.im/ticket/5381>
Pidgin <http://pidgin.im>
Pidgin