[Pidgin] #4598: Plus! color tags

Pidgin trac at pidgin.im
Sun Apr 13 19:46:06 EDT 2008


#4598: Plus! color tags
-----------------------------+----------------------------------------------
  Reporter:  daniele_athome  |       Owner:                     
      Type:  patch           |      Status:  new                
  Priority:  minor           |   Milestone:                     
 Component:  pidgin (gtk)    |     Version:  2.3.1              
Resolution:                  |    Keywords:  pidgin blist markup
   Pending:  0               |  
-----------------------------+----------------------------------------------
Comment (by rekkanoryo):

 There are a number of problems I see with this patch right off the bat:
   * // comments are not valid ANSI C.
   * Use of `g_debug` is strongly discouraged.  Use the libpurple-provided
 debugging API, which is covered quite well in the API documentation and
 the plugin howto wiki pages.
   * Parameters to functions need spaces between them.  For example,
 `foo(parm1, parm2)` instead of `foo(parm1,parm2)`.  The lack of spaces
 makes code very unreadable.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/4598#comment:3>
Pidgin <http://pidgin.im>
Pidgin


More information about the Tracker mailing list