[Pidgin] #730: Support for AdiumX "Message Styles"
Pidgin
trac at pidgin.im
Sun Apr 20 21:55:41 EDT 2008
#730: Support for AdiumX "Message Styles"
---------------------------+------------------------------------------------
Reporter: lithium | Owner: seanegan
Type: enhancement | Status: assigned
Priority: minor | Milestone:
Component: pidgin (gtk) | Version: 2.0
Resolution: | Keywords:
Pending: 0 |
---------------------------+------------------------------------------------
Changes (by QuLogic):
* milestone: 2.4.2 =>
Comment:
So, Sean, are you ever going to commit that MTN branch?
Anyway, I've been fiddling with this, and there seem to be a few changes
needed. [http://pidgin.im/~seanegan/webkit.c webkit.c] should #include
<webkit/webkitwebview.h> and <webkit/webkitnetworkrequest.h>, not
<webkitwebview.h> and <webkitnetworkrequest.h>. Additionally,
`replace_message_tokens`, `replace_header_tokens`,
`replace_template_tokens`, `get_webkit`, and `escape_message` should be
static to avoid warnings (I think that's the right fix, anyway). On line
428, there is the declaration of `GtkIMHtmlSmiley *imhtml_smiley` after
some code, so it needs to be moved up to avoid another warning.
[http://nosnilmot.com/patches/pidgin-mtn-webkit-autofoo.patch Stu's
autotools patch] needed a little tweaking as well. Pkg-config required the
name 'webkit-1.0' instead of '!WebKitGtk'. I'm not sure when this changed,
but I'm using revision 31787. Also, there's a reference to some
'Template.html', which I assume would be the default style, but webkit.c
seems to unconditionally use files from the user's directory. There's also
a ton of leaks calling g_build_filename and not g_free-ing the result, but
I assume you'll fix that when you finish that theme chooser thing
(whenever it is you get around to that, Sean!)
--
Ticket URL: <http://developer.pidgin.im/ticket/730#comment:32>
Pidgin <http://pidgin.im>
Pidgin
More information about the Tracker
mailing list