[Pidgin] #766: ICQ Xtraz Support (X-Status)

[Pidgin]

#766: ICQ Xtraz Support (X-Status)
--------------------+-------------------------------------------------------
  Reporter:  akrus  |       Owner:  MarkDoliner           
      Type:  patch  |      Status:  reopened              
  Priority:  minor  |   Milestone:                        
 Component:  ICQ    |     Version:  2.4.1                 
Resolution:         |    Keywords:  icq, xstatus, protocol
   Pending:  0      |  
--------------------+-------------------------------------------------------
Changes (by MarkDoliner):

  * status:  closed => reopened
  * resolution:  duplicate =>

Comment:

 I really don't have any time to look at this in detail, but I glanced
 through customicons4.patch:
  * Why do the icon file names start with an underscore?
  * Where did the icons come from?  Did someone make them?
  * Please don't use // style comments.  Only /* */
  * Why does purple_request_field_list_get_pixbuf() return a boolean?
 Based on the name shouldn't it return a pixbuf?
  * Maybe I'm missing something, but doesn't something need to free
 PurpleRequestField->u.list.icons and PurpleRequestField->u.list.icon_data?
 And where does PurpleRequestField->u.list.icon_data get initialized?  Is
 that hash table even used?
  * In gtkrequest.c, "if(icon == TRUE)" should be "if (icon)"
  * In family_locate.c, "if(customicon_found == FALSE)" should be "if
 (!customicon_found)"
  * There's also a little stray whitespace on some blank lines in
 family_locate.c
  * Could the parameter "no" for the aim_get_custom_icon functions be
 changed to maybe "n"?  Or "number"?

-- 
Ticket URL: <http://developer.pidgin.im/ticket/766#comment:31>
Pidgin <http://pidgin.im>
Pidgin