[Pidgin] #3264: Custom smileys in MSN chats not working

[Pidgin]

#3264: Custom smileys in MSN chats not working
---------------------+------------------------------------------------------
  Reporter:  aythun  |       Owner:  khc                              
      Type:  defect  |      Status:  new                              
  Priority:  minor   |   Milestone:                                   
 Component:  MSN     |     Version:  2.2.0                            
Resolution:          |    Keywords:  msn chat custom emoticons smileys
   Pending:  0       |  
---------------------+------------------------------------------------------
Comment (by malu):

 Replying to [ticket:3264 aythun]:
 > In MSN chats, when someone sends a custom smiley, only the text code of
 it is displayed, and a blank conversation window with that user is opened
 in the      who = msn_object_get_creator(obj);
                 sha1 = msn_object_get_sha1(obj);

                 slplink = msn_session_get_slplink(session, who);
 background. This doesn't happen in MSN conversations with a single user;
 custom smileys behave as expected.

 I see the following lines in slp.c (msn_emoticon_msg):


 {{{
                 who = msn_object_get_creator(obj);
                 sha1 = msn_object_get_sha1(obj);

                 slplink = msn_session_get_slplink(session, who);

                 conv =
 purple_find_conversation_with_account(PURPLE_CONV_TYPE_ANY, who,
 session->account);

 /* comments here... */

                 if (!conv) {
                         conv =
 purple_conversation_new(PURPLE_CONV_TYPE_IM, session->account, who);
                 }


 }}}

 I'm not that familiar with the MSN parts, but it seems to me that "who" of
 the object is the user sending the smiley, whereas the current
 conversation would be that of the chat. So I assume a new conversation
 gets spawn (if there isn't a coversation with that buddy open).
 So I guess it would have to be "redirected" to the conversation of the
 chat...

-- 
Ticket URL: <http://developer.pidgin.im/ticket/3264#comment:2>
Pidgin <http://pidgin.im>
Pidgin