[Pidgin] #4508: Custom Icons (XStatuses) support in ICQ

[Pidgin]

#4508: Custom Icons (XStatuses) support in ICQ
-----------------------+----------------------------------------------------
  Reporter:  minstrel  |       Owner:  MarkDoliner              
      Type:  patch     |      Status:  assigned                 
  Priority:  minor     |   Milestone:                           
 Component:  ICQ       |     Version:  2.3.1                    
Resolution:            |    Keywords:  Custom Icon XStatuses ICQ
   Pending:  0         |  
-----------------------+----------------------------------------------------
Comment (by MarkDoliner):

 (I left these comments on ticket #766, but I should have left them here,
 so I'll copy/paste.)  I really don't have any time to look at this in
 detail, but I glanced through customicons4.patch:

  * Why do the icon file names start with an underscore?
  * Where did the icons come from? Did someone make them?
  * Please don't use // style comments. Only /* */
  * Why does purple_request_field_list_get_pixbuf() return a boolean? Based
 on the name shouldn't it return a pixbuf?
  * Maybe I'm missing something, but doesn't something need to free
 PurpleRequestField?->u.list.icons and
 PurpleRequestField?->u.list.icon_data? And where does
 PurpleRequestField?->u.list.icon_data get initialized? Is that hash table
 even used?
  * In gtkrequest.c, "if(icon == TRUE)" should be "if (icon)"
  * In family_locate.c, "if(customicon_found == FALSE)" should be "if
 (!customicon_found)"
  * There's also a little stray whitespace on some blank lines in
 family_locate.c
  * Could the parameter "no" for the aim_get_custom_icon functions be
 changed to maybe "n"? Or "number"?

-- 
Ticket URL: <http://developer.pidgin.im/ticket/4508#comment:16>
Pidgin <http://pidgin.im>
Pidgin