[Pidgin] #4508: Custom Icons (XStatuses) support in ICQ

[Pidgin]

#4508: Custom Icons (XStatuses) support in ICQ
-----------------------+----------------------------------------------------
  Reporter:  minstrel  |       Owner:  MarkDoliner              
      Type:  patch     |      Status:  assigned                 
  Priority:  minor     |   Milestone:                           
 Component:  ICQ       |     Version:  2.3.1                    
Resolution:            |    Keywords:  Custom Icon XStatuses ICQ
   Pending:  0         |  
-----------------------+----------------------------------------------------
Comment (by ilovemistakes):

 Replying to [comment:16 MarkDoliner]:
 >  * Where did the icons come from? Did someone make them?
 afair, same icons are used in QIP.
 >  * Why does purple_request_field_list_get_pixbuf() return a boolean?
 Based on the name shouldn't it return a pixbuf?
 yes, i should name it as "get_iconed" or smth.
 >  * Maybe I'm missing something, but doesn't something need to free
 PurpleRequestField?->u.list.icons and
 PurpleRequestField?->u.list.icon_data? And where does
 PurpleRequestField?->u.list.icon_data get initialized?
 omg, that's my fault, you're right.
 > Is that hash table even used?
 no, it isn't.
 >  * Is it possible to unset the icon for yourself?
 yes, there is "None" item in "Set custom icon" dialog.[[BR]]
 no answer on other questions.
 [[BR]]
 btw, i think you should forget about "patch modifications" from #766. we
 have another, more featured now :)

 regards, Alexey

-- 
Ticket URL: <http://developer.pidgin.im/ticket/4508#comment:18>
Pidgin <http://pidgin.im>
Pidgin