[Pidgin] #4508: Custom Icons (XStatuses) support in ICQ

[Pidgin]

#4508: Custom Icons (XStatuses) support in ICQ
-----------------------+----------------------------------------------------
  Reporter:  minstrel  |       Owner:  MarkDoliner              
      Type:  patch     |      Status:  assigned                 
  Priority:  minor     |   Milestone:                           
 Component:  ICQ       |     Version:  2.3.1                    
Resolution:            |    Keywords:  Custom Icon XStatuses ICQ
   Pending:  0         |  
-----------------------+----------------------------------------------------
Comment (by minstrel):

 i'll reply only to the questions which concern my patch:

 >  * Is it possible to unset the icon for yourself?
 yes. i've implemented that in my original patch.
 >  * Why do the icon file names start with an underscore?
 they do not (see the latest patch)
 >  * Where did the icons come from? Did someone make them?
 they are taken from QIP and should be replaced with another icons...
 sorry, i'm not a designer. that might be a good opportunity for some
 volunteer :)
 >  * Please don't use // style comments. Only /* */
 Sorry, i wasn't aware of it. That doesn't seem to be a big issue anyway.
 >  * Could the parameter "no" for the aim_get_custom_icon functions be
 changed to maybe "n"? Or "number"?
 sure. "number" seems ok to me. The same applies to:
 aim_get_custom_icon_filename(gint32 no)
 aim_get_custom_icon_descriptivename(gint32 no)
 aim_get_custom_icon_data(gint32 no)
 and that's not a big issue as well.

 i won't make another patch to fix these small issues since NightFox has
 the latest stuff right now. so go ahead, dude :)

-- 
Ticket URL: <http://developer.pidgin.im/ticket/4508#comment:20>
Pidgin <http://pidgin.im>
Pidgin