[Pidgin] #5616: purple_markup_html_to_xhtml parses some attributes incorectly

Pidgin trac at pidgin.im
Wed Apr 23 20:12:12 EDT 2008


#5616: purple_markup_html_to_xhtml parses some attributes incorectly
--------------------------+-------------------------------------------------
 Reporter:  dylex         |       Type:  patch
   Status:  new           |   Priority:  minor
Component:  libpurple     |    Version:  2.4.1
 Keywords:  markup xhtml  |    Pending:  0    
--------------------------+-------------------------------------------------
 purple_markup_html_to_xhtml is not finding terminators for tag attributes
 correctly.  Most drastically, this leads to conversions such as:

 {{{<font color='green'>away</font>}}}
 to
 {{{<span style='color: green>away</font>:;'>away</span>}}}

 It doesn't match quotes correctly either (e.g., misparses `<img
 alt="abc'def">`), along with a number of other problems.

 A fix for the first problem mentioned is attached for all the places I
 could find it, but clearly a lot of this could be generalized and
 rewritten at some point.

 (I ran into this because I'm working on making
 gnt_util_parse_xhtml_to_textview work in gntconv:finch_write_common.  I
 have a reasonably working version at the moment.  Does anyone happen to
 know if there's a reason libgnt should not depend on libpurple?)

-- 
Ticket URL: <http://developer.pidgin.im/ticket/5616>
Pidgin <http://pidgin.im>
Pidgin


More information about the Tracker mailing list