[Pidgin] #5643: Wrong help message for command kick and ban
Pidgin
trac at pidgin.im
Sat Apr 26 14:44:12 EDT 2008
#5643: Wrong help message for command kick and ban
-------------------+--------------------------------------------------------
Reporter: nops | Owner: nwalp
Type: defect | Status: new
Priority: minor | Component: XMPP
Version: 2.4.1 | Keywords:
Pending: 0 |
-------------------+--------------------------------------------------------
Help messages for commands kick and ban in XMPP conversation:
{{{
/help kick
kick <user> [room]: Kick a user from the room
/help ban
ban <user> [room]: Ban a user from the room
}}}
Parameter "room" wrong - it mast be "reason".
In code this right (problem only in help text message):
functions in /libpurple/protocols/jabber/chat.c
{{{
gboolean jabber_chat_ban_user(JabberChat *chat, const char *who, const
char *why)
gboolean jabber_chat_kick_user(JabberChat *chat, const char *who, const
char *why)
}}}
this functions called from /libpurple/protocols/jabber/jabber.c:
{{{
jabber_chat_ban_user(chat, args[0], args[1])
jabber_chat_kick_user(chat, args[0], args[1])
}}}
i.e. room parameter => arg[1] => why => reason element in XMPP message
Need only change help message from "room" to "reason" or "why".
Translations need fix too.
--
Ticket URL: <http://developer.pidgin.im/ticket/5643>
Pidgin <http://pidgin.im>
Pidgin
More information about the Tracker
mailing list