#1187: Send Custom Emoticons in MSN
-----------------------+----------------------------------------------------
Reporter: salinasv | Owner: sadrul
Type: patch | Status: assigned
Priority: minor | Milestone:
Component: MSN | Version: 2.0
Resolution: | Keywords:
Pending: 0 |
-----------------------+----------------------------------------------------
Comment (by malu):
Replying to [comment:147 sadrul]:
> Revision ecbdfa4082a0e9f3e56cdbe7ebca8f3a00d6d0d9:
> {{{
> Patch from Masca to use the buddy-icon selector to select a custom
> smiley. This gives us the preview widget for free, which is really nice.
> The patch also uses the icon-selector button we use for accounts in the
> smiley dialog, which is also very cool.
> This commit also includes some changes I made to make it possible to
edit
> an existing smiley, by double clicking in the treeview. I merged this
> change with the changes in Masca's patch. I am hoping I didn't break
> anything in the process. If I did, let me know early before I forget
> whatever the heck I did!
> }}}
>
> That takes care of QuLogic's suggestions. The committed patch also
includes malu's latest patch (which I realized was there only after the
commit, which is why I couldn't acknowledge in the commit message. Sorry!
:( )
>
> Any other suggestions/bugs -- UI or API or other wise?
I noticed that when adding a smiley, the image button has the same size as
the buddy icon selector and after I had selected the icon, it was scaled
up quite up a bit.
Then when double-clicking the smiley in the mananger to edit it, the image
button was the size of the icon, which looked a bit better.
Maybe the initial size of the button could be set to a "typical smiley
size".
I assume this is because the button is orginally loaded with the buddy
icon stock image. Perhaps it could use the smiley stock image (the same as
in the toolbar/tools menu)?
I don't know if this requires big changes...
Also I noticed that when adding a new smiley and then using that smiley in
a conversation that was started before I added it, it shows up in the
smiley selector, but in the text input field the shortcut is shown. But
after sending the message the smiley appears in the conversation log.
--
Ticket URL: <http://developer.pidgin.im/ticket/1187#comment:150>
Pidgin <http://pidgin.im>
Pidgin