[Pidgin] #4449: Use MD5 login for ICQ. Fall back to XOR upon failure.

[Pidgin]

#4449: Use MD5 login for ICQ.  Fall back to XOR upon failure.
--------------------------+-------------------------------------------------
  Reporter:  MarkDoliner  |       Owner:  markdoliner    
      Type:  patch        |      Status:  new            
  Priority:  minor        |   Milestone:  Patches welcome
 Component:  ICQ          |     Version:  2.3.1          
Resolution:               |    Keywords:                 
   Pending:  0            |  
--------------------------+-------------------------------------------------
Comment (by sadrul):

 I believe the desired behaviour is not to completely disable the XOR
 method (as the second patch does). Rather, if MD5 login fails, then XOR
 method should be used, after confirmation from the user.

 I am not familiar with the oscar code, but it looks like we want to prompt
 the user for confirmation from oscar.c:purple_parse_auth_resp (when
 info->errorcode == 0x05). If you want to give it a try, take a look at
 jabber/auth.c:jabber_auth_start and see how it prompts the user before
 trying plain-text authentication.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/4449#comment:10>
Pidgin <http://pidgin.im>
Pidgin