[Pidgin] #220: Pidgin does not display pictures recieved from Gadu Gadu

Pidgin trac at pidgin.im
Fri Aug 8 10:34:25 EDT 2008


#220: Pidgin does not display pictures recieved from Gadu Gadu
------------------------+---------------------------------------------------
  Reporter:  MarkS      |       Owner:  bartosz
      Type:  patch      |      Status:  new    
  Priority:  minor      |   Milestone:         
 Component:  Gadu-Gadu  |     Version:  2.0    
Resolution:             |    Keywords:         
   Pending:  0          |  
------------------------+---------------------------------------------------
Comment (by ono):

 Okay I think the patch I just attached
 `libpurple_gg_image_support.3.patch` (reworked Sabby's) patch is good
 enough. Please check it, I've checked it with latest 7.7 client.
 @Sabby please install this patch on fresh mtn gg.c & gg.h releases, and
 try to test it. It should be safe enough to commit it into the trunk.

 In comparison to previous patch:
  * fixed UTF-8 positioning in `ggp_recv_message_handler`, so result string
 is valid UTF8 after injecting HTML tags
  * fix incoming bold, italic, etc. formatting, GG is sending empty bogus
 formatting packets, that shouldn't be treated as formatting end
  * richtext sending is now embedded in `ggp_send_im` no need for extra
 function, also safer return values
  * `purple_markup_find_tag` used for detecting `img` tags -> safer than
 g_split
  * fixed all purple_debug to include function names.. so they are more
 descriptive

-- 
Ticket URL: <http://developer.pidgin.im/ticket/220#comment:32>
Pidgin <http://pidgin.im>
Pidgin


More information about the Tracker mailing list