[Pidgin] #6715: msnp9 msn_userlist_add_buddy erroneously calls user_is_there

[Pidgin]

#6715: msnp9 msn_userlist_add_buddy erroneously calls user_is_there
------------------------+---------------------------------------------------
 Reporter:  fledermaus  |     Owner:  khc  
     Type:  defect      |    Status:  new  
Component:  MSN         |   Version:  2.4.3
 Keywords:              |  
------------------------+---------------------------------------------------
 Remove a buddy from an MSN account.
 Add them again.
 Next time you log on, you'll get a message about your buddy list being out
 of sync (local but not on server roster).

 This is because of this block of code in msn_userlist_add_buddy:

         if (user_is_there(user, list_id, group_id))
         {
                 list = lists[list_id];
                 purple_debug_error("msn", "User '%s' is already there:
 %s\n", who, list);
                 return;
         }

 which is checking something (a permissions list?) rather than
 a buddy list.

 I'm only using v 2.3.1, but the code in 2.4.3 appears identical in this
 respect.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/6715>
Pidgin <http://pidgin.im>
Pidgin